Conversation
mattdesmarais
approved these changes
Feb 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 103 103
Lines 13587 13588 +1
=======================================
+ Hits 11552 11553 +1
Misses 1518 1518
Partials 517 517
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sean-breen
approved these changes
Feb 17, 2026
dhurley
approved these changes
Feb 18, 2026
Akshay2191
approved these changes
Feb 18, 2026
craigell
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the file upload logic in FileServiceOperator to ensure that when sending files over 1MB (using chunked streaming), the agent closes the gRPC stream and waits for the NGINX One Console response only after all file chunks have been sent.
Details
Previously, the stream might not have been properly closed after sending all chunks, potentially causing incomplete uploads or missing server responses.
Now, after all chunks are sent in sendFileUpdateStreamChunks, the agent calls CloseAndRecv() on the stream client, ensuring the stream is closed and the server response is received before proceeding.
Impact
Copy of #1522 due to issue with PR
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)